Change in ovirt-engine[master]: backend: pass vdsm name over network name to vmInfo/libvirtv...
Code Review
gerrit at ovirt.org
Thu Aug 17 07:55:03 UTC 2017
>From Alona Kaplan <alkaplan at redhat.com>:
Alona Kaplan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80481 )
Change subject: backend: pass vdsm name over network name to vmInfo/libvirtvmxml
......................................................................
backend: pass vdsm name over network name to vmInfo/libvirtvmxml
The actual interface's name libvirt needs to make use of
is vdsm_name and not the network's name which is to be
used by engine. Pass vdsm_name to vmInfo and
libvirt vm's xml instead of network name.
Change-Id: Ie53dcf8cc81da8cb83b42d215e753f40cf1b727a
Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=1478806
Signed-off-by: Leon Goldberg <lgoldber at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtils.java
2 files changed, 8 insertions(+), 5 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
Leon Goldberg: Verified
--
To view, visit https://gerrit.ovirt.org/80481
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie53dcf8cc81da8cb83b42d215e753f40cf1b727a
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list