Change in ovirt-engine[master]: packaging: setup: Allow marking env keys as secret

Code Review gerrit at ovirt.org
Mon Aug 21 14:21:00 UTC 2017


>From Sandro Bonazzola <sbonazzo at redhat.com>:

Sandro Bonazzola has submitted this change and it was merged. ( https://gerrit.ovirt.org/79343 )

Change subject: packaging: setup: Allow marking env keys as secret
......................................................................


packaging: setup: Allow marking env keys as secret

Add a new parameter 'is_secret' to the decorator osetupattrs
used to create "attributed-constants".

Add keys with 'is_secret=True' to LOG_FILTER_KEYS.

Change-Id: Iab8e0807d39f04cd88de78f334d1a0c13231c4b0
Signed-off-by: Yedidyah Bar David <didi at redhat.com>
---
M packaging/setup/ovirt_engine_setup/constants.py
M packaging/setup/plugins/ovirt-engine-common/base/core/__init__.py
A packaging/setup/plugins/ovirt-engine-common/base/core/filter_secrets.py
3 files changed, 72 insertions(+), 0 deletions(-)

Approvals:
  Sandro Bonazzola: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Yedidyah Bar David: Verified



-- 
To view, visit https://gerrit.ovirt.org/79343
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iab8e0807d39f04cd88de78f334d1a0c13231c4b0
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde at redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael at rafaelmartins.eng.br>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list