Change in ovirt-engine[master]: core: store offset of vm lease as a string
Code Review
gerrit at ovirt.org
Thu Aug 24 06:27:34 UTC 2017
>From Arik Hadas <ahadas at redhat.com>:
Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/80872 )
Change subject: core: store offset of vm lease as a string
......................................................................
core: store offset of vm lease as a string
We don't use it besides putting it in the engine XML. Having it as
Integer in the database complicates the engine-side handling. Thus,
converting it into String.
Change-Id: Ie4ca6251a00c960b4d9b2c02f8fab99e54eb3f01
Bug-Id: https://bugzilla.redhat.com/1481691
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVmLeaseInfoVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/LeaseInfoReturn.java
3 files changed, 6 insertions(+), 5 deletions(-)
Approvals:
Shmuel Leib Melamud: Looks good to me, but someone else must approve
Arik Hadas: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/80872
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie4ca6251a00c960b4d9b2c02f8fab99e54eb3f01
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Gratch <sgratch at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list