Change in ovirt-engine[master]: core: Extract method to identify detached storage domain.
Code Review
gerrit at ovirt.org
Thu Aug 24 10:17:48 UTC 2017
>From Maor Lipchuk <mlipchuk at redhat.com>:
Maor Lipchuk has submitted this change and it was merged. ( https://gerrit.ovirt.org/80825 )
Change subject: core: Extract method to identify detached storage domain.
......................................................................
core: Extract method to identify detached storage domain.
Extract code which checks for null storage pool to a boolean method
to make force remove process more readable.
Change-Id: Ibe43173d3013a867be9a64243058edbfaa50989a
Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ForceRemoveStorageDomainCommand.java
1 file changed, 7 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/80825
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe43173d3013a867be9a64243058edbfaa50989a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list