Change in ovirt-engine[master]: core: minor cleanup in engine xml builder
Code Review
gerrit at ovirt.org
Thu Aug 24 14:40:10 UTC 2017
>From Arik Hadas <ahadas at redhat.com>:
Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/80899 )
Change subject: core: minor cleanup in engine xml builder
......................................................................
core: minor cleanup in engine xml builder
- Remove unused hostId field
- More concise code for iterating over map's items
- more concise code for memoization supplier definition
Change-Id: I1e215b5e398d6b70e077ca052f622a4315262fca
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java
1 file changed, 6 insertions(+), 11 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Looks good to me, but someone else must approve
Arik Hadas: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/80899
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1e215b5e398d6b70e077ca052f622a4315262fca
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list