Change in ovirt-engine[master]: core: Remove StringUtils dependency from GuidUtils

Code Review gerrit at ovirt.org
Fri Aug 25 13:45:13 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/81040 )

Change subject: core: Remove StringUtils dependency from GuidUtils
......................................................................


core: Remove StringUtils dependency from GuidUtils

Use Java's native String#split instead of StringUtils.split. While
this slightly improves the code performance (by avoiding multiple
StringBuilders), the main reason is to detach another Apache Commons
Lang dependency and set this method up for moving into Guid.

Change-Id: I819e8ca032835bb53ed84117639c64ca14c00239
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/GuidUtils.java
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/81040
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I819e8ca032835bb53ed84117639c64ca14c00239
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list