Change in ovirt-engine[master]: core: GuidUtils - use Guid::new

Code Review gerrit at ovirt.org
Fri Aug 25 13:45:13 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/81039 )

Change subject: core: GuidUtils - use Guid::new
......................................................................


core: GuidUtils - use Guid::new

Since none of the Strings being streamed can be null, using
createGuidFromStringDefaultEmpty is redundant, and a simple call to
Guid's constructor would suffice.
This change both cleans up the code, and [ever so slightly] improves
performance by omitting a null check.

Change-Id: Idb042293c031c7c6bc714125c3196a7684b7fe2e
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/GuidUtils.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/81039
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idb042293c031c7c6bc714125c3196a7684b7fe2e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list