Change in ovirt-engine[master]: core: Remove GuidUtils
Code Review
gerrit at ovirt.org
Fri Aug 25 13:45:13 UTC 2017
>From Allon Mureinik <amureini at redhat.com>:
Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/81041 )
Change subject: core: Remove GuidUtils
......................................................................
core: Remove GuidUtils
GuidUtils has a single static method, getGuidListFromString, while
Guid had all the other static methods to convert Strings to Guids.
This patch moves the method to the Guid class and renames it to
createGuidListFromString to follow the conventions of the Guid class.
Similarly, GuidUtilsTest was removed, and its tests moved to
GuidTest.
Change-Id: I921190b809b403a62baa652c313f4db13010e2f9
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveMemoryVolumesCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemover.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryUtils.java
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Guid.java
M backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/GuidTest.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainOvfInfoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/UnregisteredDisksDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmBaseDao.java
D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/GuidUtils.java
D backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/GuidUtilsTest.java
14 files changed, 71 insertions(+), 97 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/81041
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I921190b809b403a62baa652c313f4db13010e2f9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list