Change in ovirt-log-collector[master]: inventory: Remove bookmarks_query_number_of_rows
Code Review
gerrit at ovirt.org
Fri Aug 25 17:05:53 UTC 2017
>From Douglas Schilling Landgraf <dougsland at redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/81062 )
Change subject: inventory: Remove bookmarks_query_number_of_rows
......................................................................
inventory: Remove bookmarks_query_number_of_rows
It's not required, instead of doing two queries, let's use one
and check if it's only header provided, if only header do not display.
Change-Id: I9e295dc7a4acf6021e70d27ec23d1d505b17b3dd
Signed-off-by: Douglas Schilling Landgraf <dougsland at redhat.com>
---
M src/inventory_report/Makefile.am
M src/inventory_report/produceReport/produceReport.sh
D src/inventory_report/produceReport/sqls/bookmarks_query_number_of_rows.sql
3 files changed, 3 insertions(+), 20 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/81062
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9e295dc7a4acf6021e70d27ec23d1d505b17b3dd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list