Change in ovirt-engine[master]: webadmin: Correct label alignment in quota popups
Code Review
gerrit at ovirt.org
Sat Aug 26 12:58:09 UTC 2017
>From Greg Sheremeta <gshereme at redhat.com>:
Greg Sheremeta has submitted this change and it was merged. ( https://gerrit.ovirt.org/80983 )
Change subject: webadmin: Correct label alignment in quota popups
......................................................................
webadmin: Correct label alignment in quota popups
This patch corrects the spacing of the "Limit to" labels and
corresponding textboxes in the data center quota popups to
prevent wrapping of the text in the de_DE locale. It also
uppercases the first letter of the radio button label for
consistency.
-------------------
Screenshots:
Before:
Storage quota: http://imgur.com/a/MI36e
CPU/Mem quota: http://imgur.com/a/TDREO
After:
Storage quota: http://imgur.com/a/VCuJO
CPU/Mem quota: http://imgur.com/a/18A8I
Change-Id: Ic7254587347398604cfd5d5880ad5b659822a2cf
Signed-off-by: Phillip Bailey <phbailey at redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/EditQuotaClusterPopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/EditQuotaStoragePopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties
3 files changed, 15 insertions(+), 7 deletions(-)
Approvals:
Martin Sivák: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Greg Sheremeta: Looks good to me, approved
Phillip Bailey: Verified
--
To view, visit https://gerrit.ovirt.org/80983
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic7254587347398604cfd5d5880ad5b659822a2cf
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Phillip Bailey <phbailey at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir at redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey at redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list