Change in ovirt-engine[master]: webadmin: SubTabNetworkHostView improved type inference

Code Review gerrit at ovirt.org
Sun Aug 27 08:43:00 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/81069 )

Change subject: webadmin: SubTabNetworkHostView improved type inference
......................................................................


webadmin: SubTabNetworkHostView improved type inference

This patch improves the type inference of SubTabNetworkHostView to
make it a tad less robust and easier to read.
Note that in "pure" Java specifying the type of p would not be
required, but GWT's compiler isn't as powerful, and requires this
specification.

Change-Id: I123dc2ac18f2c09585647b43be60faaaa9c7fcef
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkHostView.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/81069
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I123dc2ac18f2c09585647b43be60faaaa9c7fcef
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list