Change in ovirt-engine[master]: backend: Backup feature configured for storage domain.

[Code Review]

>From Maor Lipchuk <mlipchuk at redhat.com>:

Maor Lipchuk has submitted this change and it was merged. ( https://gerrit.ovirt.org/79033 )

Change subject: backend: Backup feature configured for storage domain.
......................................................................


backend: Backup feature configured for storage domain.

This patch propose a backend support for backup storage domain.
Backup storage domain should keep the disks' data unchanged, therefore
running VMs with disks reside on the storage domain is forbidden.
To apply that restriction several validation were added:
1. VMs cannot run if one or more of their disks is in backup storage domain.
2. Disks of running VMs could not be moved or copied to a backup storage domain.
3. Backup storage domain should not be elected as master storage domain.
4. User can not activate a disk reside on a backup storage domain and attached to a running VM.
5. Export and ISO storage domains cannot be backup storage domains.

For more information about the feature see the following wiki link:
https://github.com/oVirt/ovirt-site/pull/1003

Change-Id: Ib76657e7082d07cb991c960c33ca2cff0800d4c9
Signed-off-by: Shubham Dubey <sdubey504 at gmail.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/HotPlugDiskToVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/UpdateStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateVmDisksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/HotPlugDiskToVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/AddStorageDomainCommonTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBaseTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateVmDisksCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
17 files changed, 194 insertions(+), 6 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Daniel Erez: Looks good to me, but someone else must approve
  Maor Lipchuk: Looks good to me, approved
  shubham dubey: Verified



-- 
To view, visit https://gerrit.ovirt.org/79033
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib76657e7082d07cb991c960c33ca2cff0800d4c9
Gerrit-PatchSet: 41
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: shubham dubey <sdubey504 at gmail.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-Reviewer: shubham dubey <sdubey504 at gmail.com>