Change in ovirt-engine[master]: core: Change Optional.of() to Optional.ofNullable()

Code Review gerrit at ovirt.org
Tue Aug 29 10:11:14 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/81151 )

Change subject: core: Change Optional.of() to Optional.ofNullable()
......................................................................


core: Change Optional.of() to Optional.ofNullable()

In case of receiving an empty list of images, and in order to avoid
from dealing with a NullPointerException, it's better to use
Optional.ofNullable() instead of Optional.of().

Change-Id: I2237d7329032d465a5e5ad61926598cbfa458c60
Bug-Url: https://bugzilla.redhat.com/1485951
Signed-off-by: Shani Leviim <sleviim at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/repoimage/GetImagesListQueryBase.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, approved
  Shani Leviim: Verified



-- 
To view, visit https://gerrit.ovirt.org/81151
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2237d7329032d465a5e5ad61926598cbfa458c60
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shani Leviim <sleviim at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Shani Leviim <sleviim at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list