Change in ovirt-engine[master]: core: Remove premature cast in lambda expression

Code Review gerrit at ovirt.org
Wed Aug 30 12:58:17 UTC 2017


>From Maor Lipchuk <mlipchuk at redhat.com>:

Maor Lipchuk has submitted this change and it was merged. ( https://gerrit.ovirt.org/81198 )

Change subject: core: Remove premature cast in lambda expression
......................................................................


core: Remove premature cast in lambda expression

Mapping a disk to DiskImage should be done only after the we confirm
that the disk storage type is DiskImage.
Changing the lambda expression accordingly and added the relevant tests.

Change-Id: I94a800394c6db25b50b4b2f5660e5a7de28bfc7e
Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java
2 files changed, 26 insertions(+), 3 deletions(-)

Approvals:
  Daniel Erez: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Freddy Rolland: Looks good to me, but someone else must approve
  Maor Lipchuk: Verified



-- 
To view, visit https://gerrit.ovirt.org/81198
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I94a800394c6db25b50b4b2f5660e5a7de28bfc7e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-Reviewer: shubham dubey <sdubey504 at gmail.com>


More information about the Engine-commits mailing list