Change in ovirt-engine[ovirt-engine-4.1]: core: treat template's actual disk size as editable field
Code Review
gerrit at ovirt.org
Thu Feb 2 12:06:34 UTC 2017
>From Piotr Kliczewski <piotr.kliczewski at gmail.com>:
Piotr Kliczewski has submitted this change and it was merged.
Change subject: core: treat template's actual disk size as editable field
......................................................................
core: treat template's actual disk size as editable field
This field is not being set anyway (it is generated from the template's disks)
so there is no problem in setting it as editable just for the reflection-based
validation to pass on update template.
Proper fix, however, will be to remove the actual disks size from the template.
Change-Id: I216ca19c1a060e0931390d681da8217da316a00a
Bug-Url: https://bugzilla.redhat.com/1417597
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/71566
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I216ca19c1a060e0931390d681da8217da316a00a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list