Change in ovirt-engine[master]: vdsbroker: no failover on detachSD

Code Review gerrit at ovirt.org
Sun Feb 5 09:17:05 UTC 2017


>From Liron Aravot <laravot at redhat.com>:

Liron Aravot has submitted this change and it was merged.

Change subject: vdsbroker: no failover on detachSD
......................................................................


vdsbroker: no failover on detachSD

The detach operation requires access to the domain as it modifies
its metadata - which will cause us to fail in case the domain
isn't available.
If the domain is unavailable, the detach operation fails and a failover
(assignment of the SPM role to a different host to perform retry) occurs.
As failover should help us rarely when attempting to perform detach,
this patch disables it on that scenario. The SPM can be moved to a
different host by the user if there's an actual issue related to the
host.

Change-Id: Ia6586df4ca6d9302b43bedfeec4fa8070b05412e
Bug-Url: https://bugzilla.redhat.com/1394687
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/DetachStorageDomainVDSCommand.java
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Daniel Erez: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Liron Aravot: Verified



-- 
To view, visit https://gerrit.ovirt.org/71479
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6586df4ca6d9302b43bedfeec4fa8070b05412e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list