Change in ovirt-engine[ovirt-engine-4.1]: webadmin: update actions availability of VMs list with "excl...
Code Review
gerrit at ovirt.org
Tue Feb 7 10:15:15 UTC 2017
>From Tal Nisan <tnisan at redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: update actions availability of VMs list with "exclusive" lock
......................................................................
webadmin: update actions availability of VMs list with "exclusive" lock
Updating webAdmin actions availability of VMs in VmListModel to treat a VM
in an "exclusive" memory lock and in "Down" status as if it
is in an "ImageLocked" DB status and therefore block relevant actions for it.
This is implemented by adding a new entity for overriding the getStatus()
method of the VM entity, used only by VmListModel.
This fix the problem that till now VMs in an "ImageLocked" status were checked
and relevant actions were blocked for them in Webadmin as required, but VMs in
an "exclusive" memory lock status were treated as if they are in
"Down"/"Up"/Maintenance" etc status so evethough they were in the middle of
a process like importing, relevant actions were not blocked for them as required.
Change-Id: I51776fba35828589604ca44374a7574e91b4a20c
Bug-Url: https://bugzilla.redhat.com/1364137
Signed-off-by: Sharon Gratch <sgratch at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmWithStatusForExclusiveLock.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
5 files changed, 57 insertions(+), 17 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Sharon Gratch: Verified
--
To view, visit https://gerrit.ovirt.org/71750
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I51776fba35828589604ca44374a7574e91b4a20c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Sharon Gratch <sgratch at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Gratch <sgratch at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list