Change in ovirt-engine[master]: core: optimize validation in create vm

Code Review gerrit at ovirt.org
Tue Feb 7 15:32:50 UTC 2017


>From Arik Hadas <ahadas at redhat.com>:

Arik Hadas has submitted this change and it was merged.

Change subject: core: optimize validation in create vm
......................................................................


core: optimize validation in create vm

The validation of whether or not the VM is already being initialized is done
by using Set#contains of ResourceManager#asyncRunningVms. This patch replaces
this with a check of the returned value of Set#add.

Change-Id: I60adf9e50c5b74ad43d6cefdbf534e39e6e3da4f
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVDSCommand.java
1 file changed, 31 insertions(+), 38 deletions(-)

Approvals:
  Shahar Havivi: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Shmuel Leib Melamud: Looks good to me, but someone else must approve
  Arik Hadas: Verified



-- 
To view, visit https://gerrit.ovirt.org/71703
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I60adf9e50c5b74ad43d6cefdbf534e39e6e3da4f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list