Change in ovirt-engine[ovirt-engine-4.1]: webadmin: add ui logic to WAD-EnableDiscard relationship

[Code Review]

>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: webadmin: add ui logic to WAD-EnableDiscard relationship
......................................................................


webadmin: add ui logic to WAD-EnableDiscard relationship

Previously, the user could tick the wipe after delete and enable discard
checkboxes as he wished, and only after the ok button was clicked and
the request was sent to the backend, an error would have raised in case
of an illegal configuration and the user didn't have a chance to fix it
since the popup was closed.
This patch adds the same backend logic of enable discard and its
relationship with wipe after delete to the ui in order to save the user
from disappointing after finding out about the wrong configuration too
late.

For more information about enable discard and its relationship with wipe
after delete, please refer to the feature page:
http://www.ovirt.org/develop/release-management/features/storage/pass-discard-from-guest-to-underlying-storage/

Change-Id: I912ae85e5d6dfa7bd5aad17d41d0e051e78f457e
Bug-Url: https://bugzilla.redhat.com/1414126
Signed-off-by: Idan Shaby <ishaby at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties
6 files changed, 88 insertions(+), 3 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Idan Shaby: Verified



-- 
To view, visit https://gerrit.ovirt.org/71843
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I912ae85e5d6dfa7bd5aad17d41d0e051e78f457e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>