Change in ovirt-engine[master]: core: cleanup in create vm
Code Review
gerrit at ovirt.org
Thu Feb 9 07:24:20 UTC 2017
>From Arik Hadas <ahadas at redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: cleanup in create vm
......................................................................
core: cleanup in create vm
1. Check if it's a windows VM only once.
2. Replace cumbersome if-else statements.
3. Store the VM we operate on as a class member instead
of passing it all around as local variable.
Change-Id: If50794cb983e48b9195efb1f4eb87e968e8f9783
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVDSCommand.java
1 file changed, 22 insertions(+), 14 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/71704
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If50794cb983e48b9195efb1f4eb87e968e8f9783
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list