Change in ovirt-engine-sdk-ruby[sdk_4.0]: Use 'curl-config' to detect libcurl if possible

Code Review gerrit at ovirt.org
Thu Feb 9 10:42:26 UTC 2017


>From Juan Hernandez <juan.hernandez at redhat.com>:

Juan Hernandez has submitted this change and it was merged.

Change subject: Use 'curl-config' to detect libcurl if possible
......................................................................


Use 'curl-config' to detect libcurl if possible

Currently the build process of the SDK expects the 'pkg-config' file of
the 'libcurl' library to be available, otherwise the build will fail. In
some environments (macOS, for example) this may not be available. But
curl also provides a 'curl-config' script, with similar capabilities,
that seems to be more widely available. This patch changes the
'extconf.rb' file, so that it first tries with this script, and, if it
fails, then tries with the 'pkg-config' mechanism.

Change-Id: I73e04663cfff34e7bc34d02d4a9b7493df4445b3
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
(cherry picked from commit e148e54177617c483c0e686fb9b36eb42001e226)
(cherry picked from commit de060dfb038fe68f22f9d492019e45e096c78204)
---
M sdk/ext/ovirtsdk4c/extconf.rb
1 file changed, 17 insertions(+), 7 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/71978
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I73e04663cfff34e7bc34d02d4a9b7493df4445b3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list