Change in ovirt-hosted-engine-setup[master]: upgrade: fixing vm.conf patching method
Code Review
gerrit at ovirt.org
Thu Feb 9 11:32:52 UTC 2017
>From Simone Tiraboschi <stirabos at redhat.com>:
Simone Tiraboschi has submitted this change and it was merged.
Change subject: upgrade: fixing vm.conf patching method
......................................................................
upgrade: fixing vm.conf patching method
For the first boot of the new appliance
we have to patch on the fly vm.conf to inject
the cloud-init seed image.
Patch https://gerrit.ovirt.org/67924 slightly changed
the way to read vm.conf, fixing according to it.
With the previous interface it was possible to refresh
from the shared storage (initial vm.conf or
the OVF_STORE if available) to a temporary file and
edit in place. Now we can just refresh vm.conf
in its final local destination under /var/run, read
from there, inject the cloud-init iso and write
to a temporary file as before.
Change-Id: Ib6fbbdeb5bcb84d59982c12ebdc71fb20c082b29
Bug-Url: https://bugzilla.redhat.com/1420283
Signed-off-by: Simone Tiraboschi <stirabos at redhat.com>
---
M src/plugins/gr-he-upgradeappliance/vm/runvm.py
1 file changed, 3 insertions(+), 5 deletions(-)
Approvals:
Simone Tiraboschi: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Looks good to me, but someone else must approve
Rafael Martins: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/71965
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6fbbdeb5bcb84d59982c12ebdc71fb20c082b29
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Rafael Martins <rmartins at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list