Change in ovirt-engine[master]: webadmin: disable unsetting initally assigned network role
Code Review
gerrit at ovirt.org
Sun Feb 12 14:07:07 UTC 2017
>From Alona Kaplan <alkaplan at redhat.com>:
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: disable unsetting initally assigned network role
......................................................................
webadmin: disable unsetting initally assigned network role
Make a network role checkbox not editable in manage network dialog
if that was initially set and the flow is Networks->Clusters.
Change-Id: I5983a8240a8f115c11d6ed5ee2d92d50922c934b
Bug-Url: https://bugzilla.redhat.com/1329893
Signed-off-by: Yevgeny Zaspitsky <yzaspits at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractCheckboxColumn.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties
4 files changed, 62 insertions(+), 13 deletions(-)
Approvals:
Martin Mucha: Looks good to me, but someone else must approve
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/71817
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5983a8240a8f115c11d6ed5ee2d92d50922c934b
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list