Change in ovirt-engine[master]: core: testExecuteQueryWithNotExistingIscsiBond mocking

Code Review gerrit at ovirt.org
Mon Feb 13 10:52:20 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: testExecuteQueryWithNotExistingIscsiBond mocking
......................................................................


core: testExecuteQueryWithNotExistingIscsiBond mocking

This test is supposed to test the scenario where the requested bond
does not existing in the database.
Mocking the fact that some random other bond does exist in the database
is pointless, and actually fails the test under strict mocking.

Change-Id: I3d6889c345d5e4c3b16b14158e9c4fdebb78cb56
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/connection/iscsibond/GetIscsiBondByIdQueryTest.java
1 file changed, 0 insertions(+), 4 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/72123
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3d6889c345d5e4c3b16b14158e9c4fdebb78cb56
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list