Change in ovirt-engine[master]: core: fix NPE on query from export domain

Code Review gerrit at ovirt.org
Mon Feb 13 16:51:31 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: fix NPE on query from export domain
......................................................................


core: fix NPE on query from export domain

The recent injection of OvfManager into OvfHelper requires us to inject
stuff into instances of OvfHelper. When not doing so, we are expected
to get NPEs. So this patch replaces instantiation of OvfHelper with its
injection.

Change-Id: I3ef419f1cb8d80c452dab85984f815ff99765d9c
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/GetVmsFromExportDomainQuery.java
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, approved
  Arik Hadas: Verified



-- 
To view, visit https://gerrit.ovirt.org/72206
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3ef419f1cb8d80c452dab85984f815ff99765d9c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list