Change in ovirt-engine-sdk[sdk_4.1]: Don't fork the Maven source plugin

Code Review gerrit at ovirt.org
Tue Feb 14 07:55:58 UTC 2017


>From Ondra Machacek <omachace at redhat.com>:

Ondra Machacek has submitted this change and it was merged.

Change subject: Don't fork the Maven source plugin
......................................................................


Don't fork the Maven source plugin

Currently the project runs the 'jar' goal of the Maven source plugin.u
A side effect of this is that the plugin explicitly executes the
'generate-sources' phase of the build. As a result the code generation,
which is attached to that 'generate-sources' phase, runs twice. That
doesn't have a big impact, as the generated code is the same, but it
wastes resources. This patch changes the build process so that it uses
the 'jar-no-fork', which doesn't have that negative side effect.

Change-Id: I86fffee023f4cb76992b31d2f12a481f9ab9efe8
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M pom.xml
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Ondra Machacek: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/72242
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I86fffee023f4cb76992b31d2f12a481f9ab9efe8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Ondra Machacek <omachace at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list