Change in ovirt-engine-sdk-ruby[master]: Don't use 'bundler' in RPM distributions

Code Review gerrit at ovirt.org
Tue Feb 14 10:24:50 UTC 2017


>From Juan Hernandez <juan.hernandez at redhat.com>:

Juan Hernandez has submitted this change and it was merged.

Change subject: Don't use 'bundler' in RPM distributions
......................................................................


Don't use 'bundler' in RPM distributions

Currently the SDK uses the 'bundler' tool to install the dependencies
and build the SDK. But in some platforms the latest version of this tool
doesn't work correctly with the version of the 'gem' tool. To avoid this
problem, and other potential problems in the future, this patch changes
the build scripts so that they provide a mechanism to build without
bundler. This mechanism consists on two new build profiles: 'bundler'
and 'rpm'. The first, 'bundler', will work as it used to work before
this patch. The new one, 'rpm', will assume that the required gems have
already been installed, with the RPM package manager, for example.

Note that 'bundler' is still the recommended tool for the build, and
will continue to be used in development environments and for the builds
released to 'rubygems.org'.

Change-Id: Ide97e6e6df3ca326f26563a7e3305fd50e0abc14
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M automation/build.packages.el7
M automation/build.packages.fc23
M automation/build.packages.fc24
M automation/build.py
M packaging/spec.el7.in
M packaging/spec.fc24.in
M pom.xml
M sdk/Rakefile
M sdk/pom.xml
9 files changed, 183 insertions(+), 86 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/72191
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ide97e6e6df3ca326f26563a7e3305fd50e0abc14
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list