Change in ovirt-engine[master]: core: Remove unnecessary max memory vdc_option
Code Review
gerrit at ovirt.org
Tue Feb 14 10:28:45 UTC 2017
>From Arik Hadas <ahadas at redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: Remove unnecessary max memory vdc_option
......................................................................
core: Remove unnecessary max memory vdc_option
* 0000_config.sql file no longer defines value
of VMPpc64BitMaxMemorySizeInMB. Default from ConfigValues class will
be used.
* DB script removes existing vdc_options record if it matches current
default - was not customized by user.
VM32BitMaxMemorySizeInMB and VM32BitMaxMemorySizeInMB options were not
removed since they are used in engine-config utility that can't read
defaults from ConfigValues class.
Change-Id: I72db784625edc69628857bd399a60d7fdc65e5d9
Signed-off-by: Jakub Niedermertl <jniederm at redhat.com>
---
A packaging/dbscripts/upgrade/04_02_0150_remove_VM64BitMaxMemorySizeInMB_vdc_option.sql
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
2 files changed, 6 insertions(+), 1 deletion(-)
Approvals:
Jakub Niedermertl: Verified
Martin Peřina: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/71633
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I72db784625edc69628857bd399a60d7fdc65e5d9
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list