Change in ovirt-engine[ovirt-engine-4.0]: webadmin: NPE on edit pool dialog

[Code Review]

>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: webadmin: NPE on edit pool dialog
......................................................................


webadmin: NPE on edit pool dialog

The resource allocation of the edit pool dialog has a logic which tries to
select the storage domain of the selected template to be the same as the
storage domain on which some Vm from the pool is.

The logic has an assumption that the selected template's disks are the parent
disks of the respective VM. This assumption is true only if the template is not
versioned. If the template has versions, this assumption is broken.

This causes an issue that the disk allocation part is not properly inited and
consequently fails on validation on NPE.

Fixed by first initing the storage to the values of the template disks and than
try to match them to the VM ones.

Change-Id: Iafc386b7cc4b013293c7b7f627053a438f7df7cc
Bug-Url: https://bugzilla.redhat.com/1421725
Signed-off-by: Tomas Jelinek <tjelinek at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingPoolModelBehavior.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Tomas Jelinek: Verified
  Jenkins CI: Passed CI tests
  Martin Betak: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/72197
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iafc386b7cc4b013293c7b7f627053a438f7df7cc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>