Change in ovirt-engine[master]: core: random/urandom update added to next-run snapshot

Code Review gerrit at ovirt.org
Thu Feb 16 07:48:08 UTC 2017


>From Arik Hadas <ahadas at redhat.com>:

Arik Hadas has submitted this change and it was merged.

Change subject: core: random/urandom update added to next-run snapshot
......................................................................


core: random/urandom update added to next-run snapshot

VMs that were running during cluster update 4.0 -> 4.1 didn't
get its 'random' rng updated since the 'random' -> 'urandom' change was
not included in next-run snapshot. This resulted in VM in updated
cluster with incompatible rng device that prevented the VM from running.
Fixed by including updated rng device in next-run snapshot.

Calls of RngDeviceUtils updated to pass effective compatibility version
instead of cluster version.

Bug-Url: https://bugzilla.redhat.com/1419924
Change-Id: I917108c2497a2953c7b829120b28a63626d95b29
Signed-off-by: Jakub Niedermertl <jniederm at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/RngDeviceUtils.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/HasRngDevice.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UpdateVmTemplateParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java
7 files changed, 82 insertions(+), 57 deletions(-)

Approvals:
  Jakub Niedermertl: Verified
  Jenkins CI: Passed CI tests
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/72017
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I917108c2497a2953c7b829120b28a63626d95b29
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list