Change in ovirt-engine[ovirt-engine-4.0]: db: memory_and_disk_images_storage_domain_view - EXISTS inst...

Code Review gerrit at ovirt.org
Sun Feb 19 14:02:20 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: db: memory_and_disk_images_storage_domain_view - EXISTS instead of JOIN
......................................................................


db: memory_and_disk_images_storage_domain_view - EXISTS instead of JOIN

Change Ifbedd49da added indexes and changed the
memory_and_disk_images_storage_domain_view view to use JOIN instead of EXISTS
to determine if the disk is a memory disk/ovf store. On certain datasets
and under load that causes postgres to execute the query slower.

As we yet to find a case in which using EXISTS for those tables causes
to a problem, this patch restores the use of it in the view.

Change-Id: I7daa22d37d67502836f5222fc9acaaa85881379e
Bug-Url: https://bugzilla.redhat.com/1412626
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M packaging/dbscripts/create_views.sql
1 file changed, 13 insertions(+), 6 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Liron Aravot: Verified



-- 
To view, visit https://gerrit.ovirt.org/72412
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7daa22d37d67502836f5222fc9acaaa85881379e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>


More information about the Engine-commits mailing list