Change in jenkins[master]: Make nightly publisher wait for cron job to finish

[Code Review]

>From Barak Korren <bkorren at redhat.com>:

Barak Korren has submitted this change and it was merged.

Change subject: Make nightly publisher wait for cron job to finish
......................................................................


Make nightly publisher wait for cron job to finish

Sometimes we see a race-condition formed where the cron job that
processes the result of the nightly publisher job does not finish
running before the next publisher job for the same oVirt version runs.
This can happen if something in the publisher job output makes the cron
job fail constantly or if the publisher job is manually started
frequently enough.

This patch makes the publisher job wait for up to 50 minuts for the cron
job to finish and then fail under the assumption that we're seeing a
consistent cron job failure.

This will allow detecting the so-far transparent cron failures via the
Jenkins job failures

Also re-factored the publishers YAML to DRY it up

Change-Id: I875cc4aedc65580f07e517cc606a87a5f74355ea
Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1161
Signed-off-by: Barak Korren <bkorren at redhat.com>
---
M jobs/confs/projects/ovirt/publish-rpms-nightly-3.6.yaml
M jobs/confs/projects/ovirt/publish-rpms-nightly-4.0.yaml
M jobs/confs/projects/ovirt/publish-rpms-nightly-4.1.yaml
M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml
A jobs/confs/yaml/publishers/publish-rpms-nightly.yaml
5 files changed, 83 insertions(+), 65 deletions(-)

Approvals:
  Sandro Bonazzola: Looks good to me
  Eyal Edri: Looks good to me, approved
  Barak Korren: Verified; Ready for merge
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/72634
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I875cc4aedc65580f07e517cc606a87a5f74355ea
Gerrit-PatchSet: 9
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Barak Korren <bkorren at redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk at redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren at redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde at redhat.com>
Gerrit-Reviewer: Nadav Goldin <ngoldin at redhat.com>
Gerrit-Reviewer: Pavel Zhukov <pavel at zhukoff.net>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>