Change in ovirt-engine[master]: engine: Add timeout to communication with network provider

Code Review gerrit at ovirt.org
Thu Feb 23 11:28:09 UTC 2017


>From Alona Kaplan <alkaplan at redhat.com>:

Alona Kaplan has submitted this change and it was merged.

Change subject: engine: Add timeout to communication with network provider
......................................................................


engine: Add timeout to communication with network provider

Previously there was no explicit timeout for communication to external
network provider. This way there was a long timeout applied to the
communication. Since some objects are locked during the communication,
some objects was locked for a long period of time if the external
network provided did not respond.

An explicit timeout for the communication is added, to avoid locking for
a long period of time.

The library com.woorea.openstack is used for the communication with
external network providers. The version of this library is increased to
3.1.2, which introduces the possibility to add the timeout for
communication.

Change-Id: Ic2eb1380273c811bf659ac067e6ebb65cbf31b99
Bug-Url: https://bugzilla.redhat.com/1380356
Signed-off-by: Dominik Holler <dholler at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/BaseNetworkProviderProxy.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M ovirt-engine.spec.in
M pom.xml
4 files changed, 42 insertions(+), 3 deletions(-)

Approvals:
  Sandro Bonazzola: Looks good to me, approved
  Martin Peřina: Looks good to me, but someone else must approve
  Dominik Holler: Verified
  Alona Kaplan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Yevgeny Zaspitsky: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/70135
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2eb1380273c811bf659ac067e6ebb65cbf31b99
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler <dholler at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list