Change in ovirt-engine[master]: core: add support for more than one virtio scsi controller
Code Review
gerrit at ovirt.org
Mon Feb 27 14:09:14 UTC 2017
>From Tomas Jelinek <tjelinek at redhat.com>:
Tomas Jelinek has submitted this change and it was merged.
Change subject: core: add support for more than one virtio scsi controller
......................................................................
core: add support for more than one virtio scsi controller
Since every IO Thread has to have it's own virtio scsi controller and the
current code supported only one controller, this patch adds the support for
having more than one.
If the num of io threads of a VM is lowered, the controller Id is re-generated
for this disks.
If the num of io threads is enlarged, the existing disks which already have
addresses are not re-generated, only for the new disks will be assigned to
new controller.
Therefore, in order to enforce the rearrangement of the disks to io threads
which has already been given some address, the disks have to be de-activated
and activated again. The reason is to not to touch the assignement of the disks
to controllers since it influences the disk arrangement inside of the guest.
Change-Id: I5bc8d58237ae28901bf866a50f30e87ee852c980
Bug-Url: https://bugzilla.redhat.com/1422450
Signed-off-by: Tomas Jelinek <tjelinek at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AbstractDiskVmCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtils.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilderImpl.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtilsTest.java
4 files changed, 180 insertions(+), 36 deletions(-)
Approvals:
Tomas Jelinek: Verified
Shahar Havivi: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, but someone else must approve
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/67280
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5bc8d58237ae28901bf866a50f30e87ee852c980
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list