Change in ovirt-engine[master]: core: refactoring of HostSetupNetworksCommand

[Code Review]

>From Alona Kaplan <alkaplan at redhat.com>:

Alona Kaplan has submitted this change and it was merged.

Change subject: core: refactoring of HostSetupNetworksCommand
......................................................................


core: refactoring of HostSetupNetworksCommand

• removed caching 'networksToConfigure' via getNetworksToConfigure
• removed unused fillInUnsetIpConfigs
• fixed visibilities
• minimized numbers of calculation getNetworksToConfigure
• removed 'single exit point of method' rule in defaultRouteSupported
• removed one unneeded db call to figure out management network

Change-Id: Ic26bd17a80b4d6d17585fee9e4adafd74c67d972
Bug-Url: https://bugzilla.redhat.com/1200963
Signed-off-by: Martin Mucha <mmucha at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/ManagementNetworkUtilImpl.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/ManagementNetworkUtilImplTest.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/bll/network/cluster/ManagementNetworkUtil.java
4 files changed, 111 insertions(+), 42 deletions(-)

Approvals:
  Martin Mucha: Verified
  Alona Kaplan: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/71180
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic26bd17a80b4d6d17585fee9e4adafd74c67d972
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>