Change in ovirt-engine[master]: webadmin: Refactoring unreadable code
Code Review
gerrit at ovirt.org
Tue Feb 28 15:31:00 UTC 2017
>From Alona Kaplan <alkaplan at redhat.com>:
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: Refactoring unreadable code
......................................................................
webadmin: Refactoring unreadable code
• shortened badly overgrown method by extracting anonymous classes
into inner static ones, or …
• code which cannot become inner static class was extracted as new
private method
• fixed visibility
• removed unused field
• removed duplicity
Change-Id: Ied7e0ef88fce61c6f6d176c733644b4d22ea9255
Bug-Url: https://bugzilla.redhat.com/1200963
Signed-off-by: Martin Mucha <mmucha at redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/ItemInfoPopup.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterNetworkView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkClusterView.java
4 files changed, 166 insertions(+), 186 deletions(-)
Approvals:
Jakub Niedermertl: Looks good to me, but someone else must approve
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/71183
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ied7e0ef88fce61c6f6d176c733644b4d22ea9255
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list