Change in ovirt-engine[master]: webadmin: Fixing unexpected UI behavior in the New External ...

Code Review gerrit at ovirt.org
Tue Feb 28 15:41:00 UTC 2017


>From Vojtech Szocs <vszocs at redhat.com>:

Vojtech Szocs has submitted this change and it was merged.

Change subject: webadmin: Fixing unexpected UI behavior in the New External Subnet window
......................................................................


webadmin: Fixing unexpected UI behavior in the New External Subnet window

The elements did not fit in on the panel when dns entries were added,
resulting in elements being visible outside the popup window.
Added a scroll panel.
Also enlarged the window, so that the scrollbars fit in without breaking
the panel layout.
The dns size on the subnet panel was made smaller, so that the +/- buttons
fit in. The other use of ExternalSubnetWidget in the AbstractNetworkPopupView
also looks good with the new size.
Screenshots of affected dialogs:
http://imgur.com/a/mGqaM

Change-Id: I66c8fe243299a46b743370627489ae184952af6b
Signed-off-by: Marcin Mirecki <mmirecki at redhat.com>
Bug-Url: https://bugzilla.redhat.com/1425156
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ExternalSubnetPopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/ExternalSubnetWidget.ui.xml
2 files changed, 23 insertions(+), 12 deletions(-)

Approvals:
  Marcin Mirecki: Verified
  Jenkins CI: Passed CI tests
  Greg Sheremeta: Looks good to me, approved
  Vojtech Szocs: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/73235
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I66c8fe243299a46b743370627489ae184952af6b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list