Change in ovirt-engine[master]: core: move cleanup of passthrough nics to runningFailed

[Code Review]

>From Arik Hadas <ahadas at redhat.com>:

Arik Hadas has submitted this change and it was merged.

Change subject: core: move cleanup of passthrough nics to runningFailed
......................................................................


core: move cleanup of passthrough nics to runningFailed

There are few benefits of moving the cleanup of passthrough network interfaces
to 'runningFailed' method:
1. this cleanup should be done only when the migration fails after the scheduler
chose a host (i.e., not upon an error in 'initVdss') - this is exactly what
'runningFailed' is there for.
2. it simplifies the execute ('executeVmCommand') method.
3. that way, the cleanup is done when call to VDSM for migration fails.
4. that way, the cleanup is done when the last rerun attempt fails.

Change-Id: I5b6055cd4987e75a9c8b956c061eb6452a78f124
Bug-Url: https://bugzilla.redhat.com/1408834
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
1 file changed, 33 insertions(+), 28 deletions(-)

Approvals:
  Shahar Havivi: Looks good to me, approved
  Martin Mucha: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Arik Hadas: Verified



-- 
To view, visit https://gerrit.ovirt.org/69113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5b6055cd4987e75a9c8b956c061eb6452a78f124
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>