Change in ovirt-engine[master]: core: Remove ternary operator usage in RemoveDiskCommand aud...

Code Review gerrit at ovirt.org
Thu Jan 5 10:11:24 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: core: Remove ternary operator usage in RemoveDiskCommand audit log
......................................................................


core: Remove ternary operator usage in RemoveDiskCommand audit log

Change the ternary operator usage in RemoveDiskCommand to a more readable
and more maintainable if-else condition in preparation of introducing a
new kind of audit log for disks attached to VMs

Change-Id: I623e64443e7ccd1f81f6c2053c58088f324ca3c6
Related-to: https://bugzilla.redhat.com/1391463
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/RemoveDiskCommand.java
1 file changed, 15 insertions(+), 6 deletions(-)

Approvals:
  Tal Nisan: Verified
  Daniel Erez: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Idan Shaby: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/69464
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I623e64443e7ccd1f81f6c2053c58088f324ca3c6
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list