Change in ovirt-engine[master]: core: Throw exception on VDS detach failure.

[Code Review]

>From Maor Lipchuk <mlipchuk at redhat.com>:

Maor Lipchuk has submitted this change and it was merged.

Change subject: core: Throw exception on VDS detach failure.
......................................................................


core: Throw exception on VDS detach failure.

Once the engine encounters a SanlockException during force detach
operation, the error that is being presented is an internal error
log since VDSM does not set the failure in its return value.
Instead, we should throw the exception and handle it in the bll
commands.

Change-Id: I88a7ae1a0502e75dbe371b29558422726eca63b7
Bug-Url: https://bugzilla.redhat.com/1373181
Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AttachStorageDomainToPoolCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/DetachStorageDomainVDSCommand.java
2 files changed, 12 insertions(+), 26 deletions(-)

Approvals:
  Daniel Erez: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Maor Lipchuk: Verified



-- 
To view, visit https://gerrit.ovirt.org/69800
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I88a7ae1a0502e75dbe371b29558422726eca63b7
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>