Change in ovirt-engine[master]: backend: handle video devices for vm next run

Code Review gerrit at ovirt.org
Mon Jan 9 17:06:21 UTC 2017


>From Arik Hadas <ahadas at redhat.com>:

Arik Hadas has submitted this change and it was merged.

Change subject: backend: handle video devices for vm next run
......................................................................


backend: handle video devices for vm next run

In case of updating a running VM, the createNextRunSnapshot() updates
the "Number of monitors" property in ovf only if at least one video
device exists for the VM.

Till now we always removed the video devices in
VmDeviceUtils.getVmDevicesForNextRun() - for both Headless and
non Headless VMs (since the video device will be created anyway,
based on the vm.DefaultDislayType value).

But since the "Number of Monitors" based on video device existence, this
patch makes sure such a device exists in case of non headless.

Change-Id: Ifb6e3719ccd44c8371442f928b934de37ad7ab55
Bug-Url: https://bugzilla.redhat.com/1408691
Signed-off-by: Sharon Gratch <sgratch at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
2 files changed, 27 insertions(+), 6 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Sharon Gratch: Verified
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/69624
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb6e3719ccd44c8371442f928b934de37ad7ab55
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharon Gratch <sgratch at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Gratch <sgratch at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list