Change in ovirt-engine[ovirt-engine-4.1]: core: volume initialSize calc when using collapse=true
Code Review
gerrit at ovirt.org
Wed Jan 11 16:36:13 UTC 2017
>From Tal Nisan <tnisan at redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: volume initialSize calc when using collapse=true
......................................................................
core: volume initialSize calc when using collapse=true
This patch fixes the size calculation when attempting to create a volume
that'll be in a size that'll fit all the volumes of a source image.
Currently there are two issues with the calculation:
1. The calculated initialSize isn't divided by the QCOW_OVERHEAD_FACTOR
constant.
2. Multiple roundings
Change-Id: I698ed06f721492af1bc2bb727a3198a5b33c7eba
Bug-Url: https://bugzilla.redhat.com/1411479
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainValidator.java
2 files changed, 23 insertions(+), 13 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/70022
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I698ed06f721492af1bc2bb727a3198a5b33c7eba
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list