Change in ovirt-engine[master]: core: VdsDeployBase collections

Code Review gerrit at ovirt.org
Fri Jan 13 06:29:53 UTC 2017


>From Martin Peřina <mperina at redhat.com>:

Martin Peřina has submitted this change and it was merged.

Change subject: core: VdsDeployBase collections
......................................................................


core: VdsDeployBase collections

Use standard HashMaps and ArrayLists instead of anonymously extending
them by adding default values, as per Java's best practices.

Change-Id: Ia2d59e25da424643877718e27d516f809ff55111
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployBase.java
1 file changed, 12 insertions(+), 10 deletions(-)

Approvals:
  Martin Peřina: Looks good to me, approved
  Ravi Nori: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/69786
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia2d59e25da424643877718e27d516f809ff55111
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list