Change in ovirt-engine[master]: engine : Command execution context information is only parti...

[Code Review]

>From Martin Peřina <mperina at redhat.com>:

Martin Peřina has submitted this change and it was merged.

Change subject: engine : Command execution context information is only partially persisted in the db
......................................................................


engine : Command execution context information is only partially persisted in the db

Not all command execution context
information is saved to database.

Save command execution context as json
to command_entities table and drop the
job_id and step_id fields in the table.

The JSON data is used to reconstruct the
ExecutionContext on engine restart.

Change-Id: I1e891ac39edc95927a217c77e622c7f63fb09a16
Bug-Url: https://bugzilla.redhat.com/1393459
Signed-off-by: Ravi Nori <rnori at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddStepCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EndExternalJobCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EndExternalStepCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StorageJobCallback.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionContext.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandContextsCacheImpl.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/CommandEntity.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ExecutionMethod.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/PersistedCommandContext.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/CommandEntityDaoImpl.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
M packaging/dbscripts/command_entities_sp.sql
A packaging/dbscripts/upgrade/04_02_0080_add_command_conext_to_command_entities.sql
15 files changed, 178 insertions(+), 65 deletions(-)

Approvals:
  Martin Peřina: Looks good to me, approved
  Ravi Nori: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/67953
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1e891ac39edc95927a217c77e622c7f63fb09a16
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>