Change in ovirt-engine[ovirt-engine-4.1]: aaa: Session expired message shown on SSO login page after s...
Code Review
gerrit at ovirt.org
Fri Jan 13 18:48:01 UTC 2017
>From Piotr Kliczewski <piotr.kliczewski at gmail.com>:
Piotr Kliczewski has submitted this change and it was merged.
Change subject: aaa: Session expired message shown on SSO login page after session expiration
......................................................................
aaa: Session expired message shown on SSO login page after session expiration
When the user leaves the login page open
for a period of time the session expires
and the associated SsoSession is cleaned
up. Entering user credentials and attempting
to login shows "Session expired please try
again" message.
The SsoSession object should be saved in
SsoContext with an identification token as
key which is also available on login page.
When user tried to login if the session has
expired the SsoSession can be retrieved from
the SsoContext using the session id token.
Change-Id: Idc33455751ea25e8ac77b5549e503d15b7a06960
Bug-Url: https://bugzilla.redhat.com/1411416
Signed-off-by: Ravi Nori <rnori at redhat.com>
(cherry picked from commit 823e64b93147a886fc01a4eef460910e7d4b874a)
---
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/InteractiveAuthServlet.java
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoContext.java
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoSession.java
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoUtils.java
M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/login.jsp
5 files changed, 71 insertions(+), 3 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Ravi Nori: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/70307
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idc33455751ea25e8ac77b5549e503d15b7a06960
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list