Change in ovirt-engine[master]: core: FenceValidatorTest spying

Code Review gerrit at ovirt.org
Sat Jan 14 10:31:40 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: FenceValidatorTest spying
......................................................................


core: FenceValidatorTest spying

The validator member is mocked by the @Mock annotation, and then
immediately overridden by explicitly spying it.

This patch cleans up the test initialization so the validator is only
spied in order to avoid redundant calls and make the code easier to
understand.

Change-Id: Id9791cb4481d66b1468157ce48aac39b2469bb6a
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/FenceValidatorTest.java
1 file changed, 3 insertions(+), 6 deletions(-)

Approvals:
  Martin Peřina: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/70209
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id9791cb4481d66b1468157ce48aac39b2469bb6a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list