Change in ovirt-engine[master]: core: Simplify filtering method in DeactivateStorageDomainCo...

Code Review gerrit at ovirt.org
Sun Jan 15 12:17:32 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: core: Simplify filtering method in DeactivateStorageDomainCommand
......................................................................


core: Simplify filtering method in DeactivateStorageDomainCommand

The method filterDomainsByStatus was used to filter a domain list by status
yet was only used since it was introduced to filter out non active domains
hence can be simplified to filter out only non active domains

Change-Id: I77e96de06d0c19b7855a98a5f7b980a748a84095
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/DeactivateStorageDomainCommand.java
1 file changed, 6 insertions(+), 9 deletions(-)

Approvals:
  Tal Nisan: Verified; Looks good to me, approved
  Benny Zlotnik: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Freddy Rolland: Looks good to me, but someone else must approve
  Idan Shaby: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/69968
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I77e96de06d0c19b7855a98a5f7b980a748a84095
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list