Change in ovirt-engine[master]: core: StorageDeviceSyncJobTest redundant stubbing

Code Review gerrit at ovirt.org
Mon Jan 16 21:17:48 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: StorageDeviceSyncJobTest redundant stubbing
......................................................................


core: StorageDeviceSyncJobTest redundant stubbing

Remove redundant [unused] stubbing. This unused stubbing has no effect
on the test, and just confuses the reader.
More importantly, newer Mockito versions are stricter by default, and
this will actually fail the test.

Change-Id: I035a28d57dcaf684c04171dc0375148864ea719b
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StorageDeviceSyncJobTest.java
1 file changed, 0 insertions(+), 9 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/70225
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I035a28d57dcaf684c04171dc0375148864ea719b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list