Change in ovirt-engine[master]: core: FenceVdsBaseCommand#executeCommand NPE

Code Review gerrit at ovirt.org
Tue Jan 17 08:02:10 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: FenceVdsBaseCommand#executeCommand NPE
......................................................................


core: FenceVdsBaseCommand#executeCommand NPE

The finally block can be reached with the result variable still set to
null (e.g., if setup() throws an exception).
In such a situation, checking its status will throw a
NullPointerException.

This patch solves that problem.

Change-Id: I4b0aab0181287de76d608ed534650ec5be8303b2
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/FenceVdsBaseCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified
  Moti Asayag: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/70279
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4b0aab0181287de76d608ed534650ec5be8303b2
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list