Change in ovirt-engine[master]: core: External VMs addition fix
Code Review
gerrit at ovirt.org
Tue Jan 17 09:37:55 UTC 2017
>From Arik Hadas <ahadas at redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: External VMs addition fix
......................................................................
core: External VMs addition fix
Problem: Bean validation of VmBase#maxMemorySizeMb was failing in
AddVmFromScratchCommand since it value was 0 (out of valid range). The
AddVmFromScratchCommand is called in order to add external VM to engine.
As result reporting of external VMs was broken.
Fix: Value of #maxMemorySizeMb is property copied from VDSM description
of external VM in AddUnmanagedVmsCommand#convertVm.
If 'maxMemSize' property is mising in the VDSM description then
maxMemory is set to value of memory.
Change-Id: Ie43865b3a15537bd244e3217b926955f814cfe0c
Bug-Url: https://bugzilla.redhat.com/1411739
Signed-off-by: Jakub Niedermertl <jniederm at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUnmanagedVmsCommand.java
M backend/manager/modules/bll/src/test/resources/external_vm.json
2 files changed, 7 insertions(+), 0 deletions(-)
Approvals:
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/70048
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie43865b3a15537bd244e3217b926955f814cfe0c
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list